Improve the heuristic for truncating the traceback

[invirt/packages/invirt-dev.git] / build-hooks / post-build

diff --git a/build-hooks/post-build b/build-hooks/post-build
index 10ac757..d9dfb27 100755 (executable)
--- a/build-hooks/post-build
+++ b/build-hooks/post-build
@@ -16,12 +16,13 @@ To configure zephyr, add something like the following to your invirt config:
 build:
  hooks:
   post_build:
-   zephyr: &post_build_zepyhr
+   zephyr: &post_build_zephyr
     class: myclass [required]
     instance: myinstance [optional]
     zsig: myzsig [optional]
   failed_build:
    zephyr: *post_build_zephyr
+  ...
 
 == mail ==
 
@@ -36,10 +37,18 @@ build:
     subject: My Subject [optional]
   failed_build:
    mail: *post_build_mail
+  ...
 
-post_build values will be used when this script is invoked as
-post-build, while failed_build values will be used when it is invoked
-as failed-build.
+The script chooses which configuration option to use based off the
+name it is called with.  This name also determines which command-line
+arguments the script takes, as well as how they are formatted.  When
+called as:
+
+post-build: uses post_build option
+failed-build: uses failed_build option
+post-submit: uses post_submit option
+failed-submit: uses failed_submit option
+post-add-repo: uses post_add_repo option
 """
 
 import optparse
@@ -57,8 +66,14 @@ def build_completion_msg(succeeded, values, verbose=True, success=lambda x: x, f
     """Format a message reporting the results of a build"""
     values = dict(values)
     if not verbose and values['traceback'] is not None:
-        # TODO: better heuristic
-        values['traceback'] = textwrap.fill('\n'.join(values['traceback'].split('\n')[-2:]))
+        split = values['traceback'].split('\n')
+        # Here, have a hackish heuristic
+        truncated = '(empty)'
+        for i in xrange(2, len(split)):
+            truncated = textwrap.fill('\n'.join(split[-i:]))
+            if len(truncated) >= 10:
+                break
+        values['traceback'] = truncated
 
     if succeeded:
         values['result'] = success(values['result'])
@@ -76,9 +91,28 @@ Branch %(pocket)s has been advanced to %(short_commit)s.
 (Build %(build_id)s was submitted by %(principal)s at %(inserted_at)s.)""" % values
     return msg
 
+def submit_completion_msg(succeeded, values, verbose=True, success=lambda x: x, failure=lambda x: x):
+    values = dict(values)
+    if succeeded:
+        values['result'] = success(values['result'])
+    else:
+        values['result'] = failure(values['result'])
+    msg = """Submission of %(commit)s to be built in %(pocket)s %(result)s.
+Build submitted by %(principal)s.""" % values
+    return msg
+
+def repo_creation_msg(succeeded, values, verbose=True, success=lambda x: x, failure=lambda x: x):
+    values = dict(values)
+    assert succeeded
+    msg = '%(principal)s just created a new repository, %(category)s/%(name)s.git' % values
+    return msg
+
 # Names of hooks
 POST_BUILD = 'post-build'
 FAILED_BUILD = 'failed-build'
+POST_SUBMIT = 'post-submit'
+FAILED_SUBMIT = 'failed-submit'
+POST_ADD_REPO = 'post-add-repo'
 
 # Types of communication
 
@@ -87,9 +121,15 @@ MAIL = 'mail'
 
 message_generators = {
     ZEPHYR : { POST_BUILD : build_completion_msg,
-               FAILED_BUILD : build_completion_msg },
+               FAILED_BUILD : build_completion_msg,
+               POST_SUBMIT : submit_completion_msg,
+               FAILED_SUBMIT : submit_completion_msg,
+               POST_ADD_REPO : repo_creation_msg },
     MAIL   : { POST_BUILD : build_completion_msg,
-               FAILED_BUILD : build_completion_msg }
+               FAILED_BUILD : build_completion_msg,
+               POST_SUBMIT : submit_completion_msg,
+               FAILED_SUBMIT : submit_completion_msg,
+               POST_ADD_REPO : repo_creation_msg }
     }
 
 def zephyr_escape(m):
@@ -113,6 +153,12 @@ def main():
             hook_config = config.build.hooks.post_build
         elif prog == FAILED_BUILD:
             hook_config = config.build.hooks.failed_build
+        elif prog == POST_SUBMIT:
+            hook_config = config.build.hooks.post_submit
+        elif prog == FAILED_SUBMIT:
+            hook_config = config.build.hooks.failed_submit
+        elif prog == POST_ADD_REPO:
+            hook_config = config.build.hooks.post_add_repo
         else:
             parser.error('hook script invoked with unrecognized name %s' % prog)
             return 2
@@ -148,6 +194,34 @@ def main():
             assert prog == FAILED_BUILD
             values['result'] = 'failed'
             succeeded = False
+    elif prog in [POST_SUBMIT, FAILED_SUBMIT]:
+        if len(args) != 4:
+            parser.set_usage('Usage: %prog [options] pocket package commit principal')
+            parser.print_help()
+            return 2
+        values = { 'pocket' : args[0],
+                   'package' : args[1],
+                   'commit' : args[2],
+                   'principal' : args[3],
+                   'default_instance' : 'submission',
+                   'default_subject' : 'Submission %(result)s: %(package)s %(version)s in %(pocket)s'}
+        if prog == POST_SUBMIT:
+            values['result'] = 'succeeded'
+            succeeded = True
+        else:
+            values['result'] = 'failed'
+            succeeded = False
+    elif prog in [POST_ADD_REPO]:
+        if len(args) != 3:
+            parser.set_usage('Usage: %prog [options] category name principal')
+            parser.print_help()
+            return 3
+        values = { 'category' : args[0],
+                   'name' : args[1],
+                   'principal' : args[2],
+                   'default_instance' : 'new-repo',
+                   'default_subject' : 'New repository %(category)s/%(name)s'}
+        succeeded = True
     else:
         raise AssertionError('Impossible state')