Correctly quote arguments to the installer in sipb-xen-vmcontrol

[invirt/packages/invirt-remote.git] / files / usr / sbin / sipb-xen-lvm

diff --git a/files/usr/sbin/sipb-xen-lvm b/files/usr/sbin/sipb-xen-lvm
index 304e08d..00766f6 100755 (executable)
--- a/files/usr/sbin/sipb-xen-lvm
+++ b/files/usr/sbin/sipb-xen-lvm
@@ -2,7 +2,8 @@
 
 import sys
 import os.path
 
 import sys
 import os.path

-from subprocess import call
+from subprocess import call, PIPE, Popen
+from invirt.config import structs as config

 
 def check(b):
     if not b:
 
 def check(b):
     if not b:

@@ -12,28 +13,59 @@ vg = "xenvg"
 prefix = "d_"
 
 subcommand = sys.argv[1]
 prefix = "d_"
 
 subcommand = sys.argv[1]

-machine = sys.argv[2]
-disk = sys.argv[3]
-lvname = prefix + machine + "_" + disk
-lvpath = "/dev/" + vg + "/" + lvname

 
 def ensureoff(machine):
     # Make sure the machine is off, but we don't care about errors if it is already off.
 
 def ensureoff(machine):
     # Make sure the machine is off, but we don't care about errors if it is already off.

-    rv = call(["/usr/sbin/xm", "destroy", prefix + machine])
+    rv = call(["/usr/sbin/xm", "destroy", prefix + machine],
+              stderr=PIPE)

 
 

+if subcommand == "lvcreate-all":
+    from invirt import database
+    import re
+    database.connect()
+    for d in Disk.select():
+        check(re.match('^[A-Za-z0-9]+$', d.guest_device_name))
+        machine = Machine.get(d.machine_id)
+        check(re.match('^[A-Za-z0-9][A-Za-z0-9._-]*$', machine.name))
+        lvname = prefix + machine.name + "_" + d.guest_device_name
+        if not os.path.exists("/dev/%s/%s" % (vg, lvname)):
+            # LV doesn't exist
+            print >>sys.stderr, "Creating LV %s..." % (lvname,)
+            rv = call(["/sbin/lvcreate", "-L", str(d.size) + "M", "-n", lvname, vg])
+            if rv != 0:
+                print >>sys.stderr, "Error creating LV %s\n" %(lvname,)
+                sys.exit(1)
+else:
+    machine = sys.argv[2]
+    disk = sys.argv[3]
+    lvname = prefix + machine + "_" + disk
+    lvpath = "/dev/" + vg + "/" + lvname

 if subcommand == "lvremove":
 if subcommand == "lvremove":

+    def error():
+        print >>sys.stderr, "Error removing LV %s\n" % lvname
+        sys.exit(1)
+    rv = call(["/sbin/lvchange", "-a", "n", lvpath])
+    if rv != 0:
+        error()
+    rv = call(["/sbin/lvchange", "-a", "ey", lvpath])
+    if rv != 0:
+        error()

     rv = call(["/sbin/lvremove", "--force", lvpath])
     rv = call(["/sbin/lvremove", "--force", lvpath])

-    ensureoff(machine)

     if rv != 0:
     if rv != 0:

-        print >>sys.stderr, "Error removing LV %s\n" %(lvname,)
-        sys.exit(1)
+        error()
+    ensureoff(machine)

 elif subcommand == "lvresize":
     size = sys.argv[4]
     ensureoff(machine)
 elif subcommand == "lvresize":
     size = sys.argv[4]
     ensureoff(machine)

-    rv = call(["/sbin/lvresize", "-L", size + "M", lvpath])
-    if rv != 0:
-        print >>sys.stderr, "Error resizing LV %s\n" %(lvname,)
+    p = Popen(["/sbin/lvresize", "-L", size + "M", lvpath],
+              stdin=PIPE, stderr=PIPE)
+    print >> p.stdin, 'y'
+    err = p.stderr.read()
+    if p.wait() != 0 and 'matches existing size' not in err:
+        print >> sys.stderr, "Error resizing LV %s:\n" %(lvname,)
+        print >> sys.stderr, err

         sys.exit(1)
         sys.exit(1)

+    print >> sys.stderr, err

 elif subcommand == "lvrename":
     newmachine = sys.argv[4]
     newlvname = prefix + newmachine + "_" + disk
 elif subcommand == "lvrename":
     newmachine = sys.argv[4]
     newlvname = prefix + newmachine + "_" + disk

@@ -50,20 +82,4 @@ elif subcommand == "lvcreate":
         print >>sys.stderr, "Error creating LV %s\n" %(lvname,)
         sys.exit(1)
     
         print >>sys.stderr, "Error creating LV %s\n" %(lvname,)
         sys.exit(1)
     

-elif subcommand == "lvcreate-all":
-    from sipb_xen_database import *
-    import re
-    connect('postgres://sipb-xen@sipb-xen-dev.mit.edu/sipb_xen')
-    for d in Disk.select():
-        check(re.match('^[A-Za-z0-9]+$', d.guest_device_name))
-        machine = Machine.get(d.machine_id)
-        check(re.match('^[A-Za-z0-9][A-Za-z0-9._-]*$', machine.name))
-        lvname = prefix + machine.name + "_" + d.guest_device_name
-        if not os.path.exists("/dev/%s/%s" % (vg, lvname)):
-            # LV doesn't exist
-            print >>sys.stderr, "Creating LV %s..." % (lvname,)
-            rv = call(["/sbin/lvcreate", "-L", str(d.size) + "M", "-n", lvname, vg])
-            if rv != 0:
-                print >>sys.stderr, "Error creating LV %s\n" %(lvname,)
-                sys.exit(1)