Correctly quote arguments to the installer in sipb-xen-vmcontrol

[invirt/packages/invirt-remote.git] / files / usr / sbin / sipb-xen-lvm

diff --git a/files/usr/sbin/sipb-xen-lvm b/files/usr/sbin/sipb-xen-lvm
index 183e54b..00766f6 100755 (executable)
--- a/files/usr/sbin/sipb-xen-lvm
+++ b/files/usr/sbin/sipb-xen-lvm
@@ -2,7 +2,8 @@
 
 import sys
 import os.path
-from subprocess import call, PIPE
+from subprocess import call, PIPE, Popen
+from invirt.config import structs as config
 
 def check(b):
     if not b:
@@ -15,12 +16,13 @@ subcommand = sys.argv[1]
 
 def ensureoff(machine):
     # Make sure the machine is off, but we don't care about errors if it is already off.
-    rv = call(["/usr/sbin/xm", "destroy", prefix + machine], stderr=PIPE)
+    rv = call(["/usr/sbin/xm", "destroy", prefix + machine],
+              stderr=PIPE)
 
 if subcommand == "lvcreate-all":
-    from sipb_xen_database import *
+    from invirt import database
     import re
-    connect('postgres://sipb-xen@sipb-xen-dev.mit.edu/sipb_xen')
+    database.connect()
     for d in Disk.select():
         check(re.match('^[A-Za-z0-9]+$', d.guest_device_name))
         machine = Machine.get(d.machine_id)
@@ -39,18 +41,31 @@ else:
     lvname = prefix + machine + "_" + disk
     lvpath = "/dev/" + vg + "/" + lvname
 if subcommand == "lvremove":
+    def error():
+        print >>sys.stderr, "Error removing LV %s\n" % lvname
+        sys.exit(1)
+    rv = call(["/sbin/lvchange", "-a", "n", lvpath])
+    if rv != 0:
+        error()
+    rv = call(["/sbin/lvchange", "-a", "ey", lvpath])
+    if rv != 0:
+        error()
     rv = call(["/sbin/lvremove", "--force", lvpath])
-    ensureoff(machine)
     if rv != 0:
-        print >>sys.stderr, "Error removing LV %s\n" %(lvname,)
-        sys.exit(1)
+        error()
+    ensureoff(machine)
 elif subcommand == "lvresize":
     size = sys.argv[4]
     ensureoff(machine)
-    rv = call(["/sbin/lvresize", "-L", size + "M", lvpath])
-    if rv != 0:
-        print >>sys.stderr, "Error resizing LV %s\n" %(lvname,)
+    p = Popen(["/sbin/lvresize", "-L", size + "M", lvpath],
+              stdin=PIPE, stderr=PIPE)
+    print >> p.stdin, 'y'
+    err = p.stderr.read()
+    if p.wait() != 0 and 'matches existing size' not in err:
+        print >> sys.stderr, "Error resizing LV %s:\n" %(lvname,)
+        print >> sys.stderr, err
         sys.exit(1)
+    print >> sys.stderr, err
 elif subcommand == "lvrename":
     newmachine = sys.argv[4]
     newlvname = prefix + newmachine + "_" + disk