Always exec instead of fork&exec on the remctl server so that return

codes get passed on.

svn path=/trunk/packages/invirt-remote/; revision=2094

diff --git a/debian/changelog b/debian/changelog
index fbf50b7..92d081e 100644 (file)
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,8 +2,10 @@ invirt-remote (0.3.2) unstable; urgency=low
 
   * Don't pass untrusted arguments to xm info.
   * Exit with a non-0 error code on the host if there's an error.
 
   * Don't pass untrusted arguments to xm info.
   * Exit with a non-0 error code on the host if there's an error.

+  * Always exec instead of fork&exec on the remctl server so that return
+    codes get passed on.

 
 

- -- Evan Broder <broder@mit.edu>  Sat, 31 Jan 2009 03:51:24 -0500
+ -- Evan Broder <broder@mit.edu>  Sat, 31 Jan 2009 03:51:54 -0500

 
 invirt-remote (0.3.1) unstable; urgency=low
 
 
 invirt-remote (0.3.1) unstable; urgency=low
 

diff --git a/server/usr/sbin/invirt-remote-proxy b/server/usr/sbin/invirt-remote-proxy
index f05fa65..d84fe81 100755 (executable)
--- a/server/usr/sbin/invirt-remote-proxy
+++ b/server/usr/sbin/invirt-remote-proxy
@@ -13,18 +13,18 @@ esac
 
 case "$TYPE/$SERVICE" in
     web/listvms )
 
 case "$TYPE/$SERVICE" in
     web/listvms )

-       invirt-remote-listvms "$@" ;;
+       exec invirt-remote-listvms "$@" ;;

     web/vnccert )
     web/vnccert )

-        invirt-remote-vnccert "$@" ;;
+        exec invirt-remote-vnccert "$@" ;;

     control/help )
     control/help )

-        invirt-remctl-help ;;
+        exec invirt-remctl-help ;;

     control/create|control/install )
     control/create|control/install )

-       invirt-remote-create "$SERVICE" "$MACHINE" "$@" ;;
+       exec invirt-remote-create "$SERVICE" "$MACHINE" "$@" ;;

     control/listhost|control/list-host )
     control/listhost|control/list-host )

-       invirt-remote-listhost "$MACHINE" "$@" ;;
+       exec invirt-remote-listhost "$MACHINE" "$@" ;;

     control/* )
        # Everything but create must go where the VM is already running.
     control/* )
        # Everything but create must go where the VM is already running.

-       invirt-remote-control "$MACHINE" "$SERVICE" "$@" ;;
+       exec invirt-remote-control "$MACHINE" "$SERVICE" "$@" ;;

     * )
     * )

-       remctl "$(invirt-getconf hosts.0.hostname)" remote "$TYPE" "$SERVICE" "$@" ;;
+       exec remctl "$(invirt-getconf hosts.0.hostname)" remote "$TYPE" "$SERVICE" "$@" ;;

 esac
 esac