Punt the "moocow" VNC password - it's dumb, and we already have our

[invirt/scripts/vnc-client.git] / invirt-vnc-client

diff --git a/invirt-vnc-client b/invirt-vnc-client
index 8a17f1d..186a0a8 100755 (executable)
--- a/invirt-vnc-client
+++ b/invirt-vnc-client
@@ -10,7 +10,8 @@ def usage():
     print """%s [-v] [-l [HOST:]PORT] {-a AUTHTOKEN|VMNAME}
  -l, --listen [HOST:]PORT  port (and optionally host) to listen on for
                            connections (default is 127.0.0.1 and a randomly
     print """%s [-v] [-l [HOST:]PORT] {-a AUTHTOKEN|VMNAME}
  -l, --listen [HOST:]PORT  port (and optionally host) to listen on for
                            connections (default is 127.0.0.1 and a randomly

-                           chosen port)
+                           chosen port). Use an empty HOST to listen on all
+                           interfaces (INSECURE!)

  -a, --authtoken AUTHTOKEN Authentication token for connecting to the VNC server
  VMNAME                    VM name to connect to (automatically fetches an
                            authentication token using remctl)
  -a, --authtoken AUTHTOKEN Authentication token for connecting to the VNC server
  VMNAME                    VM name to connect to (automatically fetches an
                            authentication token using remctl)

@@ -141,8 +142,9 @@ def main():
         elif o in ("-l", "--listen"):
             if ":" in a:
                 listen = a.split(":", 2)
         elif o in ("-l", "--listen"):
             if ":" in a:
                 listen = a.split(":", 2)

+                listen[1] = int(listen[1])

             else:
             else:

-                listen[1] = a
+                listen[1] = int(a)

         elif o in ("-a", "--authtoken"):
             authtoken = a
         else:
         elif o in ("-a", "--authtoken"):
             authtoken = a
         else:

@@ -157,12 +159,12 @@ def main():
             sys.exit(2)
         from subprocess import PIPE, Popen
         try:
             sys.exit(2)
         from subprocess import PIPE, Popen
         try:

-            p = Popen(["remctl", "remote", "control", args[0], "vnctoken"],
+            p = Popen(["remctl", "xvm-remote.mit.edu", "control", args[0], "vnctoken"],

                       stdout=PIPE)
         except OSError:
             if verbose: print "remctl not found in path. Trying remctl locker."
             p = Popen(["athrun", "remctl", "remctl",
                       stdout=PIPE)
         except OSError:
             if verbose: print "remctl not found in path. Trying remctl locker."
             p = Popen(["athrun", "remctl", "remctl",

-                       "remote", "control", args[0], "vnctoken"],
+                       "xvm-remote.mit.edu", "control", args[0], "vnctoken"],

                       stdout=PIPE)
         authtoken = p.communicate()[0]
         if p.returncode != 0:
                       stdout=PIPE)
         authtoken = p.communicate()[0]
         if p.returncode != 0:

@@ -190,16 +192,17 @@ def main():
     if listen[1] is None:
         listen[1] = 5900
         ready = False
     if listen[1] is None:
         listen[1] = 5900
         ready = False

-        while not ready:
+        while not ready and listen[1] < 6000:

             try:
             try:

-                reactor.listenTCP(listen[1], ProxyFactory(connect_host, connect_port, authtoken, machine))
+                reactor.listenTCP(listen[1], ProxyFactory(connect_host, connect_port, authtoken, machine), interface=listen[0])

                 ready = True
             except error.CannotListenError:
                 listen[1] += 1
     else:
         reactor.listenTCP(listen[1], ProxyFactory(connect_host, connect_port, authtoken, machine))
     
                 ready = True
             except error.CannotListenError:
                 listen[1] += 1
     else:
         reactor.listenTCP(listen[1], ProxyFactory(connect_host, connect_port, authtoken, machine))
     

-    print "Ready to connect. Connect to %s:%s (display %d) now with your VNC client. The password is 'moocow'." % (listen[0], listen[1], listen[1]-5900)
+    print "Ready to connect. Connect to %s:%s (display %d) now with your VNC"
+    print "client. There should be no password." % (listen[0], listen[1], listen[1]-5900)

     print "You must connect before your authentication token expires at %s." % \
           (time.ctime(token_expires))
     
     print "You must connect before your authentication token expires at %s." % \
           (time.ctime(token_expires))