Clean-ups to types.

[invirt/third/libt4.git] / rpc / connection.h

diff --git a/rpc/connection.h b/rpc/connection.h
index 261cf9f..1eb625b 100644 (file)
--- a/rpc/connection.h
+++ b/rpc/connection.h
@@ -5,7 +5,6 @@
 #include <sys/types.h>
 #include <arpa/inet.h>
 #include <netinet/in.h>
 #include <sys/types.h>
 #include <arpa/inet.h>
 #include <netinet/in.h>

-#include <cstddef>

 #include "pollmgr.h"
 
 constexpr size_t size_t_max = numeric_limits<size_t>::max();
 #include "pollmgr.h"
 
 constexpr size_t size_t_max = numeric_limits<size_t>::max();

@@ -16,18 +15,15 @@ class connection;
 
 class chanmgr {
     public:
 
 class chanmgr {
     public:

-        virtual bool got_pdu(connection *c, char *b, size_t sz) = 0;
+        virtual bool got_pdu(connection *c, const string & b) = 0;

         virtual ~chanmgr() {}
 };
 
 class connection : public aio_callback {
     public:
         struct charbuf {
         virtual ~chanmgr() {}
 };
 
 class connection : public aio_callback {
     public:
         struct charbuf {

-            charbuf(): buf(NULL), sz(0), solong(0) {}
-            charbuf (char *b, size_t s) : buf(b), sz(s), solong(0){}
-            char *buf;
-            size_t sz;
-            size_t solong; // number of bytes written or read so far
+            string buf;
+            size_t solong = 0; // number of bytes written or read so far

         };
 
         connection(chanmgr *m1, int f1, int lossytest=0);
         };
 
         connection(chanmgr *m1, int f1, int lossytest=0);

@@ -37,15 +33,16 @@ class connection : public aio_callback {
         bool isdead();
         void closeconn();
 
         bool isdead();
         void closeconn();
 

-        bool send(char *b, size_t sz);
+        bool send(const string & b);

         void write_cb(int s);
         void read_cb(int s);
 
         void incref();
         void decref();
         void write_cb(int s);
         void read_cb(int s);
 
         void incref();
         void decref();

-        int ref();
+        int ref() { lock rl(ref_m_); return refno_; }

 
         int compare(connection *another);
 
         int compare(connection *another);

+

     private:
 
         bool readpdu();
     private:
 
         bool readpdu();

@@ -53,16 +50,16 @@ class connection : public aio_callback {
 
         chanmgr *mgr_;
         const int fd_;
 
         chanmgr *mgr_;
         const int fd_;

-        bool dead_;
+        bool dead_ = false;

 
         charbuf wpdu_;
         charbuf rpdu_;
 
         time_point<steady_clock> create_time_;
 
 
         charbuf wpdu_;
         charbuf rpdu_;
 
         time_point<steady_clock> create_time_;
 

-        int waiters_;
-        int refno_;
-        const int lossy_;
+        int waiters_ = 0;
+        int refno_ = 1;
+        int lossy_ = 0;

 
         mutex m_;
         mutex ref_m_;
 
         mutex m_;
         mutex ref_m_;

@@ -72,12 +69,12 @@ class connection : public aio_callback {
 
 class tcpsconn {
     public:
 
 class tcpsconn {
     public:

-        tcpsconn(chanmgr *m1, unsigned int port, int lossytest=0);
+        tcpsconn(chanmgr *m1, in_port_t port, int lossytest=0);

         ~tcpsconn();
         ~tcpsconn();

-        inline unsigned int port() { return port_; }
+        inline in_port_t port() { return port_; }

         void accept_conn();
     private:
         void accept_conn();
     private:

-        unsigned int port_;
+        in_port_t port_;

         mutex m_;
         thread th_;
         int pipe_[2];
         mutex m_;
         thread th_;
         int pipe_[2];