Clean-ups

[invirt/third/libt4.git] / rpc / connection.h

diff --git a/rpc/connection.h b/rpc/connection.h
index 261cf9f..03e92da 100644 (file)
--- a/rpc/connection.h
+++ b/rpc/connection.h
@@ -2,100 +2,81 @@
 #define connection_h
 
 #include "types.h"
 #define connection_h
 
 #include "types.h"

-#include <sys/types.h>

 #include <arpa/inet.h>
 #include <netinet/in.h>
 #include <arpa/inet.h>
 #include <netinet/in.h>

-#include <cstddef>
-#include "pollmgr.h"
-
-constexpr size_t size_t_max = numeric_limits<size_t>::max();
-
-class thread_exit_exception : exception {};
+#include "t4.h"
+#include "poll_mgr.h"
+#include "file.h"
+#include "threaded_log.h"

 
 class connection;
 
 
 class connection;
 

-class chanmgr {
+class connection_delegate {

     public:
     public:

-        virtual bool got_pdu(connection *c, char *b, size_t sz) = 0;
-        virtual ~chanmgr() {}
+        virtual bool got_pdu(const shared_ptr<connection> & c, const string & b) = 0;
+        virtual ~connection_delegate();

 };
 
 };
 

-class connection : public aio_callback {
-    public:
-        struct charbuf {
-            charbuf(): buf(NULL), sz(0), solong(0) {}
-            charbuf (char *b, size_t s) : buf(b), sz(s), solong(0){}
-            char *buf;
-            size_t sz;
-            size_t solong; // number of bytes written or read so far
-        };
+using std::chrono::steady_clock;
+using time_point = std::chrono::time_point<steady_clock>;

 
 

-        connection(chanmgr *m1, int f1, int lossytest=0);
+class connection : private aio_callback, public std::enable_shared_from_this<connection> {
+    public:
+        connection(connection_delegate * delegate, socket_t && f1, int lossytest=0);

         ~connection();
 
         ~connection();
 

-        int channo() { return fd_; }
-        bool isdead();
-        void closeconn();
+        bool isdead() { return dead_; }

 
 

-        bool send(char *b, size_t sz);
-        void write_cb(int s);
-        void read_cb(int s);
+        bool send(const string & b);

 
 

-        void incref();
-        void decref();
-        int ref();
+        static shared_ptr<connection> to_dst(const sockaddr_in & dst, connection_delegate *mgr, int lossy=0);
+
+        const time_point create_time = steady_clock::now();
+        const file_t fd;

 
 

-        int compare(connection *another);

     private:
     private:

+        void write_cb(int s);
+        void read_cb(int s);

 
         bool readpdu();
         bool writepdu();
 
 
         bool readpdu();
         bool writepdu();
 

-        chanmgr *mgr_;
-        const int fd_;
-        bool dead_;
+        connection_delegate * delegate_;
+        bool dead_ = false;

 
 

-        charbuf wpdu_;
-        charbuf rpdu_;
+        enum charbuf_status_t { unused, inflight, error };

 
 

-        time_point<steady_clock> create_time_;
+        struct charbuf {
+            charbuf_status_t status;
+            string buf;
+            size_t cursor; // number of bytes written or read so far
+        };

 
 

-        int waiters_;
-        int refno_;
-        const int lossy_;
+        charbuf wpdu_ = {unused, "", 0};
+        charbuf rpdu_ = {unused, "", 0};

 
 

-        mutex m_;
-        mutex ref_m_;
+        int lossy_ = 0;
+
+        std::mutex m_;

         cond send_complete_;
         cond send_wait_;
 };
 
         cond send_complete_;
         cond send_wait_;
 };
 

-class tcpsconn {
+class connection_listener : private aio_callback {

     public:
     public:

-        tcpsconn(chanmgr *m1, unsigned int port, int lossytest=0);
-        ~tcpsconn();
-        inline unsigned int port() { return port_; }
-        void accept_conn();
+        connection_listener(connection_delegate * delegate, in_port_t port, int lossytest=0);
+        ~connection_listener();
+        inline in_port_t port() { return port_; }

     private:
     private:

-        unsigned int port_;
-        mutex m_;
-        thread th_;
-        int pipe_[2];
-
-        int tcp_; //file desciptor for accepting connection
-        chanmgr *mgr_;
-        int lossy_;
-        map<int, connection *> conns_;
+        void write_cb(int) {}
+        void read_cb(int s);

 
 

-        void process_accept();
-};
+        in_port_t port_;
+        std::mutex m_;

 
 

-struct bundle {
-    bundle(chanmgr *m, int s, int l):mgr(m),tcp(s),lossy(l) {}
-    chanmgr *mgr;
-    int tcp;
-    int lossy;
+        socket_t tcp_; // listens for connections
+        connection_delegate * delegate_;
+        int lossy_;
+        std::map<int, shared_ptr<connection>> conns_;

 };
 };

-
-connection *connect_to_dst(const sockaddr_in &dst, chanmgr *mgr, int lossy=0);

 #endif
 #endif