Refactoring

[invirt/third/libt4.git] / rpc / connection.cc

diff --git a/rpc/connection.cc b/rpc/connection.cc
index 55e374a..6c406a4 100644 (file)
--- a/rpc/connection.cc
+++ b/rpc/connection.cc
@@ -1,43 +1,39 @@
-// std::bind and syscall bind have the same name, so don't use std::bind in this file
-#define LIBT4_NO_FUNCTIONAL

 #include "connection.h"
 #include "connection.h"

+#include "rpc_protocol.h"

 #include <cerrno>
 #include <csignal>
 #include <cerrno>
 #include <csignal>

-#include <fcntl.h>
-#include <sys/types.h>

 #include <netinet/tcp.h>
 #include <unistd.h>
 #include <netinet/tcp.h>
 #include <unistd.h>

-#include <sys/socket.h>
+#include "marshall.h"

 
 

-#define MAX_PDU (10<<20) //maximum PDF is 10M
-
-connection::connection(chanmgr *m1, int f1, int l1)
-: mgr_(m1), fd_(f1), lossy_(l1)
+connection::connection(connection_delegate *m1, socket_t && f1, int l1)
+: mgr_(m1), fd_(move(f1)), lossy_(l1)

 {
 {

-    int flags = fcntl(fd_, F_GETFL, NULL);
-    fcntl(fd_, F_SETFL, flags | O_NONBLOCK);
+    fd_.flags() |= O_NONBLOCK;

 
     signal(SIGPIPE, SIG_IGN);
 
     create_time_ = steady_clock::now();
 
 
     signal(SIGPIPE, SIG_IGN);
 
     create_time_ = steady_clock::now();
 

-    PollMgr::Instance()->add_callback(fd_, CB_RDONLY, this);
+    poll_mgr::shared_mgr.add_callback(fd_, CB_RDONLY, this);

 }
 
 connection::~connection() {
 }
 
 connection::~connection() {

+    closeconn();

     VERIFY(dead_);
     VERIFY(!wpdu_.buf.size());
     VERIFY(dead_);
     VERIFY(!wpdu_.buf.size());

-    close(fd_);
-}
-
-void connection::incref() {
-    lock rl(ref_m_);
-    refno_++;

 }
 
 }
 

-bool connection::isdead() {
-    lock ml(m_);
-    return dead_;
+shared_ptr<connection> connection::to_dst(const sockaddr_in &dst, connection_delegate *mgr, int lossy) {
+    socket_t s = socket(AF_INET, SOCK_STREAM, 0);
+    s.setsockopt(IPPROTO_TCP, TCP_NODELAY, (int)1);
+    if (connect(s, (sockaddr*)&dst, sizeof(dst)) < 0) {
+        IF_LEVEL(1) LOG_NONMEMBER("failed to " << inet_ntoa(dst.sin_addr) << ":" << ntoh(dst.sin_port));
+        close(s);
+        return nullptr;
+    }
+    IF_LEVEL(2) LOG_NONMEMBER("connection::to_dst fd=" << s << " to dst " << inet_ntoa(dst.sin_addr) << ":" << ntoh(dst.sin_port));
+    return make_shared<connection>(mgr, move(s), lossy);

 }
 
 void connection::closeconn() {
 }
 
 void connection::closeconn() {

@@ -50,30 +46,7 @@ void connection::closeconn() {
     }
     //after block_remove_fd, select will never wait on fd_
     //and no callbacks will be active
     }
     //after block_remove_fd, select will never wait on fd_
     //and no callbacks will be active

-    PollMgr::Instance()->block_remove_fd(fd_);
-}
-
-void connection::decref() {
-    bool dead = false;
-    {
-        lock rl(ref_m_);
-        refno_--;
-        VERIFY(refno_>=0);
-        if (refno_==0) {
-            lock ml(m_);
-            dead = dead_;
-        }
-    }
-    if (dead)
-        delete this;
-}
-
-int connection::compare(connection *another) {
-    if (create_time_ > another->create_time_)
-        return 1;
-    if (create_time_ < another->create_time_)
-        return -1;
-    return 0;
+    poll_mgr::shared_mgr.block_remove_fd(fd_);

 }
 
 bool connection::send(const string & b) {
 }
 
 bool connection::send(const string & b) {

@@ -92,7 +65,7 @@ bool connection::send(const string & b) {
 
     if (lossy_) {
         if ((random()%100) < lossy_) {
 
     if (lossy_) {
         if ((random()%100) < lossy_) {

-            IF_LEVEL(1) LOG("connection::send LOSSY TEST shutdown fd_ " << fd_);
+            IF_LEVEL(1) LOG("send LOSSY TEST shutdown fd_ " << fd_);

             shutdown(fd_,SHUT_RDWR);
         }
     }
             shutdown(fd_,SHUT_RDWR);
         }
     }

@@ -100,11 +73,11 @@ bool connection::send(const string & b) {
     if (!writepdu()) {
         dead_ = true;
         ml.unlock();
     if (!writepdu()) {
         dead_ = true;
         ml.unlock();

-        PollMgr::Instance()->block_remove_fd(fd_);
+        poll_mgr::shared_mgr.block_remove_fd(fd_);

         ml.lock();
     } else if (wpdu_.solong != wpdu_.buf.size()) {
         // should be rare to need to explicitly add write callback
         ml.lock();
     } else if (wpdu_.solong != wpdu_.buf.size()) {
         // should be rare to need to explicitly add write callback

-        PollMgr::Instance()->add_callback(fd_, CB_WRONLY, this);
+        poll_mgr::shared_mgr.add_callback(fd_, CB_WRONLY, this);

         while (!dead_ && wpdu_.solong != size_t_max && wpdu_.solong < wpdu_.buf.size())
             send_complete_.wait(ml);
     }
         while (!dead_ && wpdu_.solong != size_t_max && wpdu_.solong < wpdu_.buf.size())
             send_complete_.wait(ml);
     }

@@ -122,11 +95,11 @@ void connection::write_cb(int s) {
     VERIFY(!dead_);
     VERIFY(fd_ == s);
     if (wpdu_.buf.size() == 0) {
     VERIFY(!dead_);
     VERIFY(fd_ == s);
     if (wpdu_.buf.size() == 0) {

-        PollMgr::Instance()->del_callback(fd_,CB_WRONLY);
+        poll_mgr::shared_mgr.del_callback(fd_,CB_WRONLY);

         return;
     }
     if (!writepdu()) {
         return;
     }
     if (!writepdu()) {

-        PollMgr::Instance()->del_callback(fd_, CB_RDWR);
+        poll_mgr::shared_mgr.del_callback(fd_, CB_RDWR);

         dead_ = true;
     } else {
         VERIFY(wpdu_.solong != size_t_max);
         dead_ = true;
     } else {
         VERIFY(wpdu_.solong != size_t_max);

@@ -137,31 +110,29 @@ void connection::write_cb(int s) {
     send_complete_.notify_one();
 }
 
     send_complete_.notify_one();
 }
 

-//fd_ is ready to be read
+// fd_ is ready to be read

 void connection::read_cb(int s) {
     lock ml(m_);
     VERIFY(fd_ == s);
 void connection::read_cb(int s) {
     lock ml(m_);
     VERIFY(fd_ == s);

-    if (dead_)  {
+    if (dead_)

         return;
         return;

-    }

 
     IF_LEVEL(5) LOG("got data on fd " << s);
 
     bool succ = true;
 
     IF_LEVEL(5) LOG("got data on fd " << s);
 
     bool succ = true;

-    if (!rpdu_.buf.size() || rpdu_.solong < rpdu_.buf.size()) {
+    if (!rpdu_.buf.size() || rpdu_.solong < rpdu_.buf.size())

         succ = readpdu();
         succ = readpdu();

-    }

 
     if (!succ) {
         IF_LEVEL(5) LOG("readpdu on fd " << s << " failed; dying");
 
     if (!succ) {
         IF_LEVEL(5) LOG("readpdu on fd " << s << " failed; dying");

-        PollMgr::Instance()->del_callback(fd_,CB_RDWR);
+        poll_mgr::shared_mgr.del_callback(fd_,CB_RDWR);

         dead_ = true;
         send_complete_.notify_one();
     }
 
     if (rpdu_.buf.size() && rpdu_.buf.size() == rpdu_.solong) {
         dead_ = true;
         send_complete_.notify_one();
     }
 
     if (rpdu_.buf.size() && rpdu_.buf.size() == rpdu_.solong) {

-        if (mgr_->got_pdu(this, rpdu_.buf)) {
-            //chanmgr has successfully consumed the pdu
+        if (mgr_->got_pdu(shared_from_this(), rpdu_.buf)) {
+            // connection_delegate has successfully consumed the pdu

             rpdu_.buf.clear();
             rpdu_.solong = 0;
         }
             rpdu_.buf.clear();
             rpdu_.solong = 0;
         }

@@ -173,14 +144,10 @@ bool connection::writepdu() {
     if (wpdu_.solong == wpdu_.buf.size())
         return true;
 
     if (wpdu_.solong == wpdu_.buf.size())
         return true;
 

-    if (wpdu_.solong == 0) {
-        uint32_t sz = htonl((uint32_t)wpdu_.buf.size() - sizeof(uint32_t));
-        copy((const char *)&sz, (const char *)(&sz+1), &wpdu_.buf[0]);
-    }

     ssize_t n = write(fd_, &wpdu_.buf[wpdu_.solong], (wpdu_.buf.size()-wpdu_.solong));
     if (n < 0) {
         if (errno != EAGAIN) {
     ssize_t n = write(fd_, &wpdu_.buf[wpdu_.solong], (wpdu_.buf.size()-wpdu_.solong));
     if (n < 0) {
         if (errno != EAGAIN) {

-            IF_LEVEL(1) LOG("connection::writepdu fd_ " << fd_ << " failure errno=" << errno);
+            IF_LEVEL(1) LOG("writepdu fd_ " << fd_ << " failure errno=" << errno);

             wpdu_.solong = size_t_max;
             wpdu_.buf.clear();
         }
             wpdu_.solong = size_t_max;
             wpdu_.buf.clear();
         }

@@ -193,12 +160,11 @@ bool connection::writepdu() {
 bool connection::readpdu() {
     IF_LEVEL(5) LOG("the receive buffer has length " << rpdu_.buf.size());
     if (!rpdu_.buf.size()) {
 bool connection::readpdu() {
     IF_LEVEL(5) LOG("the receive buffer has length " << rpdu_.buf.size());
     if (!rpdu_.buf.size()) {

-        uint32_t sz1;
-        ssize_t n = read(fd_, &sz1, sizeof(sz1));
+        rpc_sz_t sz1;
+        ssize_t n = fd_.read(sz1);

 
 

-        if (n == 0) {
+        if (n == 0)

             return false;
             return false;

-        }

 
         if (n < 0) {
             VERIFY(errno!=EAGAIN);
 
         if (n < 0) {
             VERIFY(errno!=EAGAIN);

@@ -210,7 +176,7 @@ bool connection::readpdu() {
             return false;
         }
 
             return false;
         }
 

-        size_t sz = ntohl(sz1);
+        size_t sz = ntoh(sz1);

 
         if (sz > MAX_PDU) {
             IF_LEVEL(2) LOG("read pdu TOO BIG " << sz << " network order=" << hex << sz1);
 
         if (sz > MAX_PDU) {
             IF_LEVEL(2) LOG("read pdu TOO BIG " << sz << " network order=" << hex << sz1);

@@ -221,11 +187,10 @@ bool connection::readpdu() {
 
         VERIFY(rpdu_.buf.size() == 0);
         rpdu_.buf = string(sz+sizeof(sz1), 0);
 
         VERIFY(rpdu_.buf.size() == 0);
         rpdu_.buf = string(sz+sizeof(sz1), 0);

-        copy((const char *)&sz1, (const char *)(&sz1 + 1), &rpdu_.buf[0]);

         rpdu_.solong = sizeof(sz1);
     }
 
         rpdu_.solong = sizeof(sz1);
     }
 

-    ssize_t n = read(fd_, &rpdu_.buf[rpdu_.solong], rpdu_.buf.size() - rpdu_.solong);
+    ssize_t n = fd_.read(&rpdu_.buf[rpdu_.solong], rpdu_.buf.size() - rpdu_.solong);

 
     IF_LEVEL(5) LOG("read " << n << " bytes");
 
 
     IF_LEVEL(5) LOG("read " << n << " bytes");
 

@@ -240,63 +205,55 @@ bool connection::readpdu() {
     return true;
 }
 
     return true;
 }
 

-tcpsconn::tcpsconn(chanmgr *m1, unsigned int port, int lossytest)
-: mgr_(m1), lossy_(lossytest)
+tcpsconn::tcpsconn(connection_delegate *m1, in_port_t port, int lossytest)
+: tcp_(socket(AF_INET, SOCK_STREAM, 0)), mgr_(m1), lossy_(lossytest)

 {
 {

-    struct sockaddr_in sin;
+    sockaddr_in sin;

     memset(&sin, 0, sizeof(sin));
     sin.sin_family = AF_INET;
     memset(&sin, 0, sizeof(sin));
     sin.sin_family = AF_INET;

-    sin.sin_port = htons(port);
+    sin.sin_port = hton(port);

 
 

-    tcp_ = socket(AF_INET, SOCK_STREAM, 0);
-    if (tcp_ < 0) {
-        perror("accept_loop socket:");
-        VERIFY(0);
-    }
+    tcp_.setsockopt(SOL_SOCKET, SO_REUSEADDR, (int)1);
+    tcp_.setsockopt(IPPROTO_TCP, TCP_NODELAY, (int)1);
+
+    if (tcp_.setsockopt(SOL_SOCKET, SO_RCVTIMEO, timeval{0, 50000}) < 0)
+        perror("accept_loop setsockopt");

 
 

-    int yes = 1;
-    setsockopt(tcp_, SOL_SOCKET, SO_REUSEADDR, &yes, sizeof(yes));
-    setsockopt(tcp_, IPPROTO_TCP, TCP_NODELAY, &yes, sizeof(yes));
+    if (tcp_.setsockopt(SOL_SOCKET, SO_SNDTIMEO, timeval{0, 50000}) < 0)
+        perror("accept_loop setsockopt");

 
 

-    if (bind(tcp_, (sockaddr *)&sin, sizeof(sin)) < 0) {
-        perror("accept_loop tcp bind:");
+    // careful to exactly match type signature of bind arguments so we don't
+    // get std::bind instead
+    if (bind((int)tcp_, (const sockaddr *)&sin, (socklen_t)sizeof(sin)) < 0) {
+        perror("accept_loop bind");

         VERIFY(0);
     }
 
     if (listen(tcp_, 1000) < 0) {
         VERIFY(0);
     }
 
     if (listen(tcp_, 1000) < 0) {

-        perror("listen:");
+        perror("accept_loop listen");

         VERIFY(0);
     }
 
     socklen_t addrlen = sizeof(sin);
     VERIFY(getsockname(tcp_, (sockaddr *)&sin, &addrlen) == 0);
         VERIFY(0);
     }
 
     socklen_t addrlen = sizeof(sin);
     VERIFY(getsockname(tcp_, (sockaddr *)&sin, &addrlen) == 0);

-    port_ = ntohs(sin.sin_port);
+    port_ = ntoh(sin.sin_port);

 
     IF_LEVEL(2) LOG("listen on " << port_ << " " << sin.sin_port);
 
 
     IF_LEVEL(2) LOG("listen on " << port_ << " " << sin.sin_port);
 

-    if (pipe(pipe_) < 0) {
-        perror("accept_loop pipe:");
-        VERIFY(0);
-    }
+    file_t::pipe(pipe_);

 
 

-    int flags = fcntl(pipe_[0], F_GETFL, NULL);
-    flags |= O_NONBLOCK;
-    fcntl(pipe_[0], F_SETFL, flags);
+    pipe_[0].flags() |= O_NONBLOCK;

 
     th_ = thread(&tcpsconn::accept_conn, this);
 }
 
 tcpsconn::~tcpsconn()
 {
 
     th_ = thread(&tcpsconn::accept_conn, this);
 }
 
 tcpsconn::~tcpsconn()
 {

-    VERIFY(close(pipe_[1]) == 0);
+    pipe_[1].close();

     th_.join();
 
     th_.join();
 

-    //close all the active connections
-    map<int, connection *>::iterator i;
-    for (i = conns_.begin(); i != conns_.end(); i++) {
-        i->second->closeconn();
-        i->second->decref();
-    }
+    for (auto & i : conns_)
+        i.second->closeconn();

 }
 
 void tcpsconn::process_accept() {
 }
 
 void tcpsconn::process_accept() {

@@ -308,20 +265,14 @@ void tcpsconn::process_accept() {
         throw thread_exit_exception();
     }
 
         throw thread_exit_exception();
     }
 

-    IF_LEVEL(2) LOG("accept_loop got connection fd=" << s1 << " " << inet_ntoa(sin.sin_addr) << ":" << ntohs(sin.sin_port));
-    connection *ch = new connection(mgr_, s1, lossy_);
+    IF_LEVEL(2) LOG("accept_loop got connection fd=" << s1 << " " << inet_ntoa(sin.sin_addr) << ":" << ntoh(sin.sin_port));
+    auto ch = make_shared<connection>(mgr_, s1, lossy_);

 
 

-    // garbage collect all dead connections with refcount of 1
+    // garbage collect dead connections

     for (auto i = conns_.begin(); i != conns_.end();) {
     for (auto i = conns_.begin(); i != conns_.end();) {

-        if (i->second->isdead() && i->second->ref() == 1) {
-            IF_LEVEL(2) LOG("accept_loop garbage collected fd=" << i->second->channo());
-            i->second->decref();
-            // Careful not to reuse i right after erase. (i++) will
-            // be evaluated before the erase call because in C++,
-            // there is a sequence point before a function call.
-            // See http://en.wikipedia.org/wiki/Sequence_point.
+        if (i->second->isdead())

             conns_.erase(i++);
             conns_.erase(i++);

-        } else
+        else

             ++i;
     }
 
             ++i;
     }
 

@@ -330,53 +281,33 @@ void tcpsconn::process_accept() {
 
 void tcpsconn::accept_conn() {
     fd_set rfds;
 
 void tcpsconn::accept_conn() {
     fd_set rfds;

-    int max_fd = pipe_[0] > tcp_ ? pipe_[0] : tcp_;
-
-    try {
-        while (1) {
-            FD_ZERO(&rfds);
-            FD_SET(pipe_[0], &rfds);
-            FD_SET(tcp_, &rfds);
-
-            int ret = select(max_fd+1, &rfds, NULL, NULL, NULL);
-
-            if (ret < 0) {
-                if (errno == EINTR) {
-                    continue;
-                } else {
-                    perror("accept_conn select:");
-                    IF_LEVEL(0) LOG("tcpsconn::accept_conn failure errno " << errno);
-                    VERIFY(0);
-                }
-            }
-
-            if (FD_ISSET(pipe_[0], &rfds)) {
-                close(pipe_[0]);
-                close(tcp_);
-                return;
-            }
-            else if (FD_ISSET(tcp_, &rfds)) {
-                process_accept();
-            } else {
-                VERIFY(0);
-            }
+    int max_fd = max((int)pipe_[0], (int)tcp_);
+
+    while (1) {
+        FD_ZERO(&rfds);
+        FD_SET(pipe_[0], &rfds);
+        FD_SET(tcp_, &rfds);
+
+        int ret = select(max_fd+1, &rfds, NULL, NULL, NULL);
+
+        if (ret < 0 && errno == EINTR)
+            continue;
+        else if (ret < 0) {
+            perror("accept_conn select:");
+            IF_LEVEL(0) LOG("accept_conn failure errno " << errno);
+            VERIFY(0);

         }
         }

-    }
-    catch (thread_exit_exception e)
-    {
-    }
-}

 
 

-connection * connect_to_dst(const sockaddr_in &dst, chanmgr *mgr, int lossy) {
-    int s = socket(AF_INET, SOCK_STREAM, 0);
-    int yes = 1;
-    setsockopt(s, IPPROTO_TCP, TCP_NODELAY, &yes, sizeof(yes));
-    if (connect(s, (sockaddr*)&dst, sizeof(dst)) < 0) {
-        IF_LEVEL(1) LOG_NONMEMBER("rpcc::connect_to_dst failed to " << inet_ntoa(dst.sin_addr) << ":" << ntohs(dst.sin_port));
-        close(s);
-        return NULL;
+        if (FD_ISSET(pipe_[0], &rfds))
+            return;
+
+        VERIFY(FD_ISSET(tcp_, &rfds));
+
+        try {
+            process_accept();
+        } catch (thread_exit_exception e) {
+            break;
+        }

     }
     }

-    IF_LEVEL(2) LOG_NONMEMBER("connect_to_dst fd=" << s << " to dst " << inet_ntoa(dst.sin_addr) << ":" << ntohs(dst.sin_port));
-    return new connection(mgr, s, lossy);

 }
 
 }