Cosmetic improvements.

[invirt/third/libt4.git] / rpc / marshall.h

diff --git a/rpc/marshall.h b/rpc/marshall.h
index 0e0af8d..7b716e2 100644 (file)
--- a/rpc/marshall.h
+++ b/rpc/marshall.h
@@ -4,21 +4,18 @@
 #include "types.h"
 #include "rpc_protocol.h"
 
-class marshall;
-class unmarshall;
-
 //
 // Marshall and unmarshall objects
 //
 
 class marshall {
     private:
-        string buf_ = string(DEFAULT_RPC_SZ, 0); // Raw bytes buffer
-        size_t index_ = RPC_HEADER_SZ; // Read/write head position
+        string buf_ = string(rpc_protocol::DEFAULT_RPC_SZ, 0); // Raw bytes buffer
+        size_t index_ = rpc_protocol::RPC_HEADER_SZ; // Read/write head position
 
     public:
         template <typename... Args>
-        marshall(const Args&... args) {
+        marshall(const Args & ... args) {
             (void)pass{(*this << args)...};
         }
 
@@ -32,14 +29,14 @@ class marshall {
         // with header
         inline operator string() const { return buf_.substr(0,index_); }
         // without header
-        inline string content() { return buf_.substr(RPC_HEADER_SZ,index_-RPC_HEADER_SZ); }
+        inline string content() const { return buf_.substr(rpc_protocol::RPC_HEADER_SZ,index_-rpc_protocol::RPC_HEADER_SZ); }
 
         // letting S be a defaulted template parameter forces the compiler to
-        // delay looking up operator<<(marshall&, rpc_sz_t) until we define it
+        // delay looking up operator<<(marshall &, rpc_sz_t) until we define it
         // (i.e. we define an operator for marshalling uint32_t)
-        template <class T, class S=rpc_sz_t> inline void
+        template <class T, class S=rpc_protocol::rpc_sz_t> inline void
         pack_header(const T & h) {
-            VERIFY(sizeof(T)+sizeof(S) <= RPC_HEADER_SZ);
+            VERIFY(sizeof(T)+sizeof(S) <= rpc_protocol::RPC_HEADER_SZ);
             size_t saved_sz = index_;
             index_ = 0;
             *this << (S)(saved_sz - sizeof(S)) << (T)h;
@@ -54,12 +51,13 @@ class unmarshall {
         bool ok_ = false;
 
     public:
-        unmarshall() {}
-        unmarshall(const string &s, bool has_header)
-            : buf_(s),index_(RPC_HEADER_SZ) {
+        template <typename... Args>
+        unmarshall(const string & s, bool has_header, Args && ... args)
+            : buf_(s),index_(rpc_protocol::RPC_HEADER_SZ) {
             if (!has_header)
-                buf_.insert(0, RPC_HEADER_SZ, 0);
-            ok_ = (buf_.size() >= RPC_HEADER_SZ);
+                buf_.insert(0, rpc_protocol::RPC_HEADER_SZ, 0);
+            ok_ = (buf_.size() >= rpc_protocol::RPC_HEADER_SZ);
+            (void)pass{(*this >> args)...};
         }
 
         bool ok() const { return ok_; }
@@ -73,16 +71,16 @@ class unmarshall {
             index_ += n;
         }
 
-        template <class T> void
+        template <class T> inline void
         unpack_header(T & h) {
-            VERIFY(sizeof(T)+sizeof(rpc_sz_t) <= RPC_HEADER_SZ);
+            VERIFY(sizeof(T)+sizeof(rpc_protocol::rpc_sz_t) <= rpc_protocol::RPC_HEADER_SZ);
             // first 4 bytes hold length field
-            index_ = sizeof(rpc_sz_t);
+            index_ = sizeof(rpc_protocol::rpc_sz_t);
             *this >> h;
-            index_ = RPC_HEADER_SZ;
+            index_ = rpc_protocol::RPC_HEADER_SZ;
         }
 
-        template <class T> inline T grab() { T t; *this >> t; return t; }
+        template <class T> inline T _grab() { T t; *this >> t; return t; }
 };
 
 //
@@ -90,8 +88,8 @@ class unmarshall {
 //
 
 #define MARSHALL_RAW_NETWORK_ORDER_AS(_c_, _d_) \
-inline marshall & operator<<(marshall &m, _c_ x) { _d_ y = hton((_d_)x); m.rawbytes(&y, sizeof(_d_)); return m; } \
-inline unmarshall & operator>>(unmarshall &u, _c_ &x) { _d_ y; u.rawbytes(&y, sizeof(_d_)); x = (_c_)ntoh(y); return u; }
+inline marshall & operator<<(marshall & m, _c_ x) { _d_ y = hton((_d_)x); m.rawbytes(&y, sizeof(_d_)); return m; } \
+inline unmarshall & operator>>(unmarshall & u, _c_ & x) { _d_ y; u.rawbytes(&y, sizeof(_d_)); x = (_c_)ntoh(y); return u; }
 
 #define MARSHALL_RAW_NETWORK_ORDER(_c_) MARSHALL_RAW_NETWORK_ORDER_AS(_c_, _c_)
 
@@ -134,13 +132,13 @@ operator<<(marshall & m, tuple<Args...> && t) {
 }
 
 template <class... Args, size_t... Indices> inline unmarshall &
-tuple_unmarshall_imp(unmarshall & u, tuple<Args &...> t, tuple_indices<Indices...>) {
+tuple_unmarshall_imp(unmarshall & u, tuple<Args & ...> t, tuple_indices<Indices...>) {
     (void)pass{(u >> get<Indices>(t))...};
     return u;
 }
 
 template <class... Args> unmarshall &
-operator>>(unmarshall & u, tuple<Args &...> && t) {
+operator>>(unmarshall & u, tuple<Args & ...> && t) {
     using Indices = typename make_tuple_indices<sizeof...(Args)>::type;
     return tuple_unmarshall_imp(u, t, Indices());
 }
@@ -150,13 +148,13 @@ operator>>(unmarshall & u, tuple<Args &...> && t) {
 //
 
 // Implements struct marshalling via tuple marshalling of members.
-#define MARSHALLABLE(_c_) \
-inline unmarshall & operator>>(unmarshall &u, _c_ &a) { return u >> a._tuple_(); } \
-inline marshall & operator<<(marshall &m, const _c_ a) { return m << a._tuple_(); }
+#define MARSHALLABLE_STRUCT(_c_) \
+inline unmarshall & operator>>(unmarshall & u, _c_ & a) { return u >> a._tuple_(); } \
+inline marshall & operator<<(marshall & m, const _c_ a) { return m << a._tuple_(); }
 
 // our first two marshallable structs...
-MARSHALLABLE(request_header)
-MARSHALLABLE(reply_header)
+MARSHALLABLE_STRUCT(rpc_protocol::request_header)
+MARSHALLABLE_STRUCT(rpc_protocol::reply_header)
 
 //
 // Marshalling for STL containers
@@ -165,9 +163,9 @@ MARSHALLABLE(reply_header)
 // this overload is visible for type A only if A::cbegin and A::cend exist
 template <class A> inline typename
 enable_if<is_const_iterable<A>::value, marshall>::type &
-operator<<(marshall &m, const A &x) {
+operator<<(marshall & m, const A & x) {
     m << (unsigned int)x.size();
-    for (const auto &a : x)
+    for (const auto & a : x)
         m << a;
     return m;
 }
@@ -175,44 +173,44 @@ operator<<(marshall &m, const A &x) {
 // visible for type A if A::emplace_back(a) makes sense
 template <class A> inline typename
 enable_if<supports_emplace_back<A>::value, unmarshall>::type &
-operator>>(unmarshall &u, A &x) {
-    unsigned n = u.grab<unsigned>();
+operator>>(unmarshall & u, A & x) {
+    unsigned n = u._grab<unsigned>();
     x.clear();
     while (n--)
-        x.emplace_back(u.grab<typename A::value_type>());
+        x.emplace_back(u._grab<typename A::value_type>());
     return u;
 }
 
 // std::pair<A, B>
 template <class A, class B> inline marshall &
-operator<<(marshall &m, const pair<A,B> &d) {
+operator<<(marshall & m, const pair<A,B> & d) {
     return m << d.first << d.second;
 }
 
 template <class A, class B> inline unmarshall &
-operator>>(unmarshall &u, pair<A,B> &d) {
+operator>>(unmarshall & u, pair<A,B> & d) {
     return u >> d.first >> d.second;
 }
 
 // std::map<A, B>
 template <class A, class B> inline unmarshall &
-operator>>(unmarshall &u, map<A,B> &x) {
-    unsigned n = u.grab<unsigned>();
+operator>>(unmarshall & u, map<A,B> & x) {
+    unsigned n = u._grab<unsigned>();
     x.clear();
     while (n--)
-        x.emplace(u.grab<pair<A,B>>());
+        x.emplace(u._grab<pair<A,B>>());
     return u;
 }
 
 // std::string
-inline marshall & operator<<(marshall &m, const string &s) {
+inline marshall & operator<<(marshall & m, const string & s) {
     m << (uint32_t)s.size();
     m.rawbytes(s.data(), s.size());
     return m;
 }
 
-inline unmarshall & operator>>(unmarshall &u, string &s) {
-    uint32_t sz = u.grab<uint32_t>();
+inline unmarshall & operator>>(unmarshall & u, string & s) {
+    uint32_t sz = u._grab<uint32_t>();
     if (u.ok()) {
         s.resize(sz);
         u.rawbytes(&s[0], sz);
@@ -225,13 +223,26 @@ inline unmarshall & operator>>(unmarshall &u, string &s) {
 //
 
 template <class E> typename enable_if<is_enum<E>::value, marshall>::type &
-operator<<(marshall &m, E e) {
+operator<<(marshall & m, E e) {
     return m << from_enum(e);
 }
 
 template <class E> typename enable_if<is_enum<E>::value, unmarshall>::type &
-operator>>(unmarshall &u, E &e) {
-    e = to_enum<E>(u.grab<enum_type_t<E>>());
+operator>>(unmarshall & u, E & e) {
+    e = to_enum<E>(u._grab<enum_type_t<E>>());
+    return u;
+}
+
+//
+// Recursive marshalling
+//
+
+inline marshall & operator<<(marshall & m, marshall & n) {
+    return m << n.content();
+}
+
+inline unmarshall & operator>>(unmarshall & u, unmarshall & v) {
+    v = unmarshall(u._grab<string>(), false);
     return u;
 }