X-Git-Url: http://xvm.mit.edu/gitweb/invirt/third/libt4.git/blobdiff_plain/5bb7eb131773abd9e642f83629528b4c4e706b2e..a5f10a497bebfc680bf418193f1fd9f1ad7cc417:/rsm.h

diff --git a/rsm.h b/rsm.h
index ef919ff..1e1726d 100644
--- a/rsm.h
+++ b/rsm.h
@@ -12,7 +12,7 @@
 class rsm_state_transfer {
     public:
         virtual string marshal_state() = 0;
-        virtual void unmarshal_state(string) = 0;
+        virtual void unmarshal_state(const string &) = 0;
         virtual ~rsm_state_transfer() {}
 };
 
@@ -43,23 +43,22 @@ class rsm : public config_view_change {
         bool break2;
 
         rsm_client_protocol::status client_members(vector<string> &r, int i);
-        rsm_protocol::status invoke(int &, int proc, viewstamp vs, string mreq);
-        rsm_protocol::status transferreq(rsm_protocol::transferres &r, string src,
+        rsm_protocol::status invoke(int &, int proc, viewstamp vs, const string & mreq);
+        rsm_protocol::status transferreq(rsm_protocol::transferres &r, const string & src,
                 viewstamp last, unsigned vid);
-        rsm_protocol::status transferdonereq(int &, string m, unsigned vid);
-        rsm_protocol::status joinreq(string & log, string src,
-                viewstamp last);
+        rsm_protocol::status transferdonereq(int &, const string & m, unsigned vid);
+        rsm_protocol::status joinreq(string & log, const string & src, viewstamp last);
         rsm_test_protocol::status test_net_repairreq(rsm_test_protocol::status &r, int heal);
         rsm_test_protocol::status breakpointreq(rsm_test_protocol::status &r, int b);
 
         mutex rsm_mutex, invoke_mutex;
         cond recovery_cond, sync_cond;
 
-        void execute(int procno, string req, string &r);
-        rsm_client_protocol::status client_invoke(string &r, int procno, string req);
-        bool statetransfer(string m, lock & rsm_mutex_lock);
-        bool statetransferdone(string m, lock & rsm_mutex_lock);
-        bool join(string m, lock & rsm_mutex_lock);
+        void execute(int procno, const string & req, string & r);
+        rsm_client_protocol::status client_invoke(string & r, int procno, const string & req);
+        bool statetransfer(const string & m, lock & rsm_mutex_lock);
+        bool statetransferdone(const string & m, lock & rsm_mutex_lock);
+        bool join(const string & m, lock & rsm_mutex_lock);
         void set_primary(unsigned vid);
         bool sync_with_backups(lock & rsm_mutex_lock);
         bool sync_with_primary(lock & rsm_mutex_lock);
@@ -69,8 +68,7 @@ class rsm : public config_view_change {
         void partition1(lock & rsm_mutex_lock);
         void commit_change(unsigned vid, lock & rsm_mutex_lock);
     public:
-        rsm (string _first, string _me);
-        ~rsm() {}
+        rsm (const string & _first, const string & _me);
 
         bool amiprimary();
         void set_state_transfer(rsm_state_transfer *_stf) { stf = _stf; }