X-Git-Url: http://xvm.mit.edu/gitweb/invirt/third/libt4.git/blobdiff_plain/f0dcb6b97d6d40f67698d1f71ac26970f1776f82..c279db4240a3a3c30f069ab9dea8055cf94280da:/rpc/rpc.h

diff --git a/rpc/rpc.h b/rpc/rpc.h
index 211c717..df5d89e 100644
--- a/rpc/rpc.h
+++ b/rpc/rpc.h
@@ -2,32 +2,39 @@
 #define rpc_h
 
 #include "types.h"
-#include <sys/socket.h>
-#include <netinet/in.h>
 
 #include "rpc_protocol.h"
-#include "thr_pool.h"
+#include "thread_pool.h"
 #include "marshall.h"
 #include "marshall_wrap.h"
 #include "connection.h"
+#include "threaded_log.h"
+
+using std::chrono::milliseconds;
 
 namespace rpc {
     static constexpr milliseconds to_max{12000};
     static constexpr milliseconds to_min{100};
 }
 
-template<class P, class R, class ...Args> struct is_valid_call : false_type {};
+template<class P, class R, class ...Args>
+struct is_valid_call : false_type {};
 
 template<class S, class R, class ...Args>
 struct is_valid_call<S(R &, Args...), R, Args...> : true_type {};
 
-template<class P, class F> struct is_valid_registration : false_type {};
+template<class P, class F>
+struct is_valid_registration : false_type {};
 
 template<class S, class R, class ...Args>
-struct is_valid_registration<S(R &, typename decay<Args>::type...), S(R &, Args...)> : true_type {};
+struct is_valid_registration<
+    S(R &, typename std::decay<Args>::type...),
+    S(R &, Args...)> : true_type {};
 
 template<class P, class C, class S, class R, class ...Args>
-struct is_valid_registration<P, S(C::*)(R &, Args...)> : is_valid_registration<P, S(R &, Args...)> {};
+struct is_valid_registration<
+    P,
+    S(C::*)(R &, Args...)> : is_valid_registration<P, S(R &, Args...)> {};
 
 // rpc client endpoint.
 // manages a xid space per destination socket
@@ -48,7 +55,7 @@ class rpcc : private connection_delegate {
             string *rep;
             int intret;
             bool done = false;
-            mutex m;
+            std::mutex m;
             cond c;
         };
 
@@ -65,17 +72,18 @@ class rpcc : private connection_delegate {
 
         shared_ptr<connection> chan_;
 
-        mutex m_; // protect insert/delete to calls[]
-        mutex chan_m_;
+        std::mutex m_; // protect insert/delete to calls[]
+        std::mutex chan_m_;
+        std::mutex bind_m_; // protect bind operations
 
         bool destroy_wait_ = false;
         cond destroy_wait_c_;
 
-        map<int, caller *> calls_;
+        std::map<int, caller *> calls_;
 
         // xid starts with 1 and latest received reply starts with 0
         xid_t xid_ = 1;
-        list<xid_t> xid_rep_window_ = {0};
+        std::list<xid_t> xid_rep_window_ = {0};
 
         struct request {
             void clear() { buf.clear(); xid = -1; }
@@ -95,8 +103,8 @@ class rpcc : private connection_delegate {
             if (intret < 0) return intret;
             unmarshall u(rep, true, r);
             if (u.okdone() != true) {
-                LOG("rpcc::call_m: failed to unmarshall the reply.  You are probably " <<
-                    "calling RPC 0x" << hex << proc << " with the wrong return type.");
+                LOG << "rpcc::call_m: failed to unmarshall the reply.  You are probably "
+                    << "calling RPC 0x" << std::hex << proc << " with the wrong return type.";
                 VERIFY(0);
                 return rpc_protocol::unmarshall_reply_failure;
             }
@@ -114,9 +122,17 @@ class rpcc : private connection_delegate {
 
         int bind(milliseconds to = rpc::to_max);
 
+        // Manages a cache of RPC connections.  Usage:
+        //     if (auto cl = rpcc::bind_cached(dst))
+        //         ret = cl->call(...);
+        // where the string dst has the form "host:port".  Because bind_cached()
+        // may block, callers should probably not hold mutexes.
+        static shared_ptr<rpcc> bind_cached(const string & destination);
+        static void unbind_cached(const string & destination);
+
         void set_reachable(bool r) { reachable_ = r; }
 
-        void cancel();
+        void cancel(lock & m_lock);
 
         template<class P, class R, typename ...Args>
         inline int call(proc_t<P> proc, R & r, const Args & ... args) {
@@ -126,7 +142,7 @@ class rpcc : private connection_delegate {
         template<class P, class R, typename ...Args>
         inline int call_timeout(proc_t<P> proc, milliseconds to, R & r, const Args & ... args) {
             static_assert(is_valid_call<P, R, Args...>::value, "RPC called with incorrect argument types");
-            return call_m(proc.id, to, r, forward<marshall>(marshall(args...)));
+            return call_m(proc.id, to, r, std::forward<marshall>(marshall(args...)));
         }
 };
 
@@ -164,7 +180,7 @@ class rpcs : private connection_delegate {
         // provide at most once semantics by maintaining a window of replies
         // per client that that client hasn't acknowledged receiving yet.
         // indexed by client nonce.
-        map<nonce_t, list<reply_t>> reply_window_;
+        std::map<nonce_t, std::list<reply_t>> reply_window_;
 
         void add_reply(nonce_t clt_nonce, xid_t xid, const string & b);
 
@@ -172,20 +188,20 @@ class rpcs : private connection_delegate {
                 xid_t rep_xid, string & b);
 
         // latest connection to the client
-        map<nonce_t, shared_ptr<connection>> conns_;
+        std::map<nonce_t, shared_ptr<connection>> conns_;
 
         bool reachable_ = true;
 
         // map proc # to function
-        map<proc_id_t, handler *> procs_;
+        std::map<proc_id_t, handler *> procs_;
 
-        mutex procs_m_; // protect insert/delete to procs[]
-        mutex reply_window_m_; // protect reply window et al
-        mutex conns_m_; // protect conns_
+        std::mutex procs_m_; // protect insert/delete to procs[]
+        std::mutex reply_window_m_; // protect reply window et al
+        std::mutex conns_m_; // protect conns_
 
         void dispatch(shared_ptr<connection> c, const string & buf);
 
-        unique_ptr<thread_pool> dispatchpool_{new thread_pool(6, false)};
+        unique_ptr<thread_pool> dispatchpool_{new thread_pool(6)};
         unique_ptr<connection_listener> listener_;
 
         // RPC handler for clients binding