In the invirt-janitor, ignore errors from the dd.
authorEvan Broder <broder@mit.edu>
Wed, 12 Aug 2009 03:01:07 +0000 (23:01 -0400)
committerEvan Broder <broder@mit.edu>
Wed, 12 Aug 2009 03:01:07 +0000 (23:01 -0400)
In the normal case, it's erroring out because of ENOSPC, but its
return code isn't useful enough to make sure that's what happened.

svn path=/trunk/packages/invirt-remote/; revision=2437

host/usr/sbin/invirt-janitor

index 75a637a..e631972 100755 (executable)
@@ -42,13 +42,15 @@ def cleanup():
         try:
             syslog.syslog(syslog.LOG_INFO, "Cleaning up LV '%s'" % lv_path)
 
         try:
             syslog.syslog(syslog.LOG_INFO, "Cleaning up LV '%s'" % lv_path)
 
-            subprocess.check_call(['/usr/bin/ionice',
-                                   '-c', '2',
-                                   '-n', '7',
-                                   '/bin/dd',
-                                   'if=/dev/zero',
-                                   'of=%s' % lv_path,
-                                   'bs=1M'])
+            # In a perfect world, this should be erroring out with
+            # ENOSPC, so we ignore errors
+            subprocess.call(['/usr/bin/ionice',
+                             '-c', '2',
+                             '-n', '7',
+                             '/bin/dd',
+                             'if=/dev/zero',
+                             'of=%s' % lv_path,
+                             'bs=1M'])
 
             # Ignore any errors here, because there's really just not
             # anything we can do.
 
             # Ignore any errors here, because there's really just not
             # anything we can do.