Incorporate broder's comments.

Signed-off-by: Edward Z. Yang <edwardzyang@thewritingpot.com>

diff --git a/afs/_acl.pyx b/afs/_acl.pyx
index 5f0360b..06736f9 100644 (file)
--- a/afs/_acl.pyx
+++ b/afs/_acl.pyx
@@ -37,8 +37,7 @@ DEF MAXSIZE = 2048
 def getAcl(char* dir, int follow=1):
     cdef char space[MAXSIZE]
     pioctl_read(dir, VIOCGETAL, space, MAXSIZE, follow)
 def getAcl(char* dir, int follow=1):
     cdef char space[MAXSIZE]
     pioctl_read(dir, VIOCGETAL, space, MAXSIZE, follow)

-    ret = space # Python managed string
-    return ret
+    return space

 
 def getCallerAccess(char *dir, int follow=1):
     cdef vcxstat2 stat
 
 def getCallerAccess(char *dir, int follow=1):
     cdef vcxstat2 stat

diff --git a/afs/acl.py b/afs/acl.py
index d9a6df4..a245aa2 100644 (file)
--- a/afs/acl.py
+++ b/afs/acl.py
@@ -48,9 +48,9 @@ class ACL(object):
         self.pos = pos
         self.neg = neg
     @staticmethod
         self.pos = pos
         self.neg = neg
     @staticmethod

-    def retrieve(dir):
+    def retrieve(dir,follow=1):

         """Retrieve the ACL for an AFS directory"""
         """Retrieve the ACL for an AFS directory"""

-        pos, neg = _parseAcl(_acl.getAcl(dir))
+        pos, neg = _parseAcl(_acl.getAcl(dir, follow))

         return ACL(pos, neg)
 
 def showRights(r):
         return ACL(pos, neg)
 
 def showRights(r):